Thread Rating:
  • 13 Vote(s) - 3.15 Average
  • 1
  • 2
  • 3
  • 4
  • 5
[Module] Party Follow Assist v4
#5
I'm going to make a few suggestions based on what I see here..

A) There's several very "expensive" things happening in an non-throttled Draw loop, which is not great. The Draw loop happens on every frame, and a lot of your logic (and pretty much all logic in general) really shouldn't be there. NavigationManager:GetClosestPointOnMesh and Player:MoveTo especially. These should be moved to an OnUpdate with some minimum throttle amount.
B) The global variables should be pushed into the PartyFollowAssist table (ex: PartyFollowAssist.Enable instead of Enable) or given more proper names to distinguish them, because they will pollute the global space, and could accidentally be overridden.

+1 for taking initiative though, good job.
Reply
 


Messages In This Thread
[Module] Party Follow Assist v4 - by HusbandoMax - 07-02-2016, 11:06 PM
RE: [Module] Party Follow Assist - by Scorpy - 07-02-2016, 11:25 PM
RE: [Module] Party Follow Assist - by Underwhelp - 07-03-2016, 12:28 AM
RE: [Module] Party Follow Assist - by Ace - 07-04-2016, 03:49 AM
RE: [Module] Party Follow Assist v2 - by kslcom - 07-05-2016, 12:22 AM
RE: [Module] Party Follow Assist v2 - by kslcom - 07-05-2016, 01:24 AM
RE: [Module] Party Follow Assist v2 - by kslcom - 07-05-2016, 03:48 AM
RE: [Module] Party Follow Assist v4 - by modena - 02-23-2017, 05:12 AM
RE: [Module] Party Follow Assist v4 - by modena - 02-23-2017, 09:14 AM

Forum Jump:


Users browsing this thread: 3 Guest(s)

We help you win the game.

FFXIV Bot and More.

 

Products