[dek]

same problems as the same posters up top, cannot add any of the legendaries aside from the ones I already have in my profiles

[naab67]

Hello , thanks you for this great addons/module , i noticed that i can't fish Olghoi Khorkoi , i found out the reason , the weather condition , as writed in your module is "Heat Wave" , when the true weather condition is "Heat Waves" , i tryed to rewrite the weather condition by myself but it never save it , thanks to do a patch to fix it =)

[chicagosteamer]

Awesome module, however I can't use it non-stop as it drops my framerate down to about 1fps.

I currently can only use it to create a marker for me, then I shut it off then use the vanilla fishing bot.

I've read over everything here, as well as other fishing guides. I'm not getting a string of error messages in the console. My machine is up to spec, and don't have frame rate issues with any other module.

Any idea what could be causing this? Any suggestions to try? I'm slightly comfortable navigating lua - should I look anywhere specific?

Thanks!

[Ace]

It won't be a lua problem, it will be a problem with using an external exe. The gameloop is basically being handcuffed while waiting for the return value from the .exe, so it strangles the framerate until it completes its process.

[edb6377]

First off thank you for creating a useful module :)

One Note, When looking at my task manager i see a TON of weather collectors, command prompts and consoles. I assume this is because you are instantiating a new instance each time its called instead of reusing it or closing it when you are done.

Just thought I would let you know. It wasn't the end of the world but on less powerful machines I could see where it could tie things up a bit

[Proto]

same problems as the same posters up top, cannot add any of the legendaries aside from the ones I already have in my profiles

anyone know why this is happening?

[edb6377]

I have seen if you add certain ones liike some of the 2.0 fish it screws up the entire profile and I had to recreate it and skip those fish.

[mysticarchives]

I'm not sure what triggered it, but I installed 1.2.1 and ended up with 8 copies of weathertracker and cmd prompt instances running. Wouldn't have even noticed had it not lagged out my game so bad.
Rebooted and trying again, but figured i'd report the occurrence. If it happens again i'll probably roll back to 1.1.2, i hadn't had any issues using earlier versions.
-------------------------
Turned out that 1.1.2 was doing it too, but it didn't effect my system performance so i didn't notice it. Will keep using 1.1.2 for the mean time, but I might need to roll back to 1.1 or something since its throwing out all the fish even though no boxes are checked. I normally wouldn't mind, but trying to burn through small time windows and throwing stuff back takes more time than just bagging it for npc value later. Specially when you got fish that are only open for 5-9 minutes per window.
--------------------------
Forward notice that I by no means take credit for the work, but for those that are experiencing FPS issues w/ 1.2.1 this is a link for 1.1.2
https://www.dropbox.com/s/y13wygminqw1o7...2.zip?dl=0

I also have 1.1.1 if anybody wants a historical copy for some reason.

[KaWeNGoD]

The problem is the GETID function. You should made an array with names and IDs (not IDs and names) with baits and fishes and use the array not the funcion, you are looping the 11k elements array every 500 ms more than once.

I did the test and it's ok for me now.

[edb6377]

I am sure it will get updated when the OP has time but yeah the extra exes running, the busted ID's that break the profiles and the parsing of the array appear to be the next things that need fixed.